Hmmm.... @Neustradamus we might be too late for this (is 23.05 is still being built?)
Hopefully the failed checks are just due to buildbot upgrades and this can still be backported. This would provide netatalk on stable build.

@APCCV: 23.05.x is always good, not EOL yet.

Took out last two commits enabling AppleTalk as more work is required to get it fully working. The previous 4 commits are solid and provide netatalk support for 23.05.

I get that servers are failing CI checks because they are being upgraded... any chance we can merge so this package becomes available in 23.05 while upgrades are in progress? These are 4 cherry-picked commits that build fine in 24.10 and snapshot.

There we go. All green.
It's not easy being green.

@APCCV: Good job!
All the users community will be happy!

@Neustradamus Ha. Nobody but you and I have seen this PR yet. Don't get too excited.

@ OpenWrt maintainers: please merge with 23.05. AppleTalk functionality has issues with DSA images but works beautifully with 23.05. It might be the case that 23.05 is the last release that supports AppleTalk. It would be really awesome if we can get AppleTalk in the last service release of 23.05.

Note that applies only to AppleTalk feature. AFPD (Apple File Sharing through IP) works great in 23.05, 24.10 & snapshot.

@BKPepe - apologies for the ping... but I would hate to miss the opportunity to get out a fully working AppleTalk daemon on an OpenWrt release. Full disclosure - for that to happen I will also need to PR a change to openwrt (not packages) so kmod-appletalk is also included in 23.05. I will submit that PR once this one is merged.
Even if that second PR for backport is not accepted there is still value with a working AFP daemon in 23.05.
If there is a policy not to proceed with merge given 24.10 is branched already, please close.

I hope that it will be possible to add the latest possibility in OpenWrt 23.05.x.
The World needs it.

@hauke, @hnyman: What do you think?

for that to happen I will also need to PR a change to openwrt (not packages) so kmod-appletalk is also included in 23.05. I will submit that PR once this one is merged.

the kmod should be merged first to the main OpenWrt repo, I think, and this PR should depend on that getting accepted.

merged first to the main OpenWrt repo

Hey, @hnyman, thank you for taking a look. Snapshot and 24.10 are both up to date.

Snapshot - module: 5eb25dddb17fa3cf4958e91dfc9fc868c9eb03ac
Snapshot - package: 07efd50

24.10 - module: b2f3713
24.10 - package: 6952117

All tested and working on two targets, ipq806x and ath79. (Well... again, being transparent, DSA enabled caused a separate issue for which I have a patch ready but that is not applicable to 23.05).

The netatalk package can stand alone for AFP support. AFP (main feature in this package) doesn't require the module. AppleTalk (feature now available in v4) does. There is much value in merging this PR even without the kmod.

I will submit the PR for backport of the module and cross-reference.

PR for appletalk kmod sent... but (apologies for repeating) that is a very much "nice to have" for this package. Netatalk v4 will deliver functioning Apple File Sharing Protocol (AFPD) without the kmod.
With the kmod it will also deliver a functioning AppleTalk (atalkd).

@APCCV: Good job, thanks!
Thanks to @hnyman for merging :)