Skip to content

fix: ts-cli command line argument 'precision' has no effect#540

Merged
xiangyu5632 merged 3 commits into
openGemini:mainfrom
localvar:fix-513
Apr 2, 2024
Merged

fix: ts-cli command line argument 'precision' has no effect#540
xiangyu5632 merged 3 commits into
openGemini:mainfrom
localvar:fix-513

Conversation

@localvar

@localvar localvar commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

ts-cli command line argument precision has no effect.

Issue Number: fix #513

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@localvar
fix: ts-cli command line argument 'precision' has no effect
e87e235 
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
@localvar localvar marked this pull request as ready for review March 29, 2024 07:18
@localvar
fix: test case failure
736cc8d 
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
@codecov

codecov Bot commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (8bb41f0) to head (2524b5c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   74.79%   74.74%   -0.05%     
==========================================
  Files         550      553       +3     
  Lines      117505   117700     +195     
==========================================
+ Hits        87887    87977      +90     
- Misses      24223    24322      +99     
- Partials     5395     5401       +6

@localvar localvar marked this pull request as draft April 1, 2024 00:54
@localvar
fix: integration test failures
2524b5c 
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
@localvar localvar marked this pull request as ready for review April 1, 2024 06:16
@xiangyu5632

xiangyu5632 commented Apr 2, 2024

Copy link
Copy Markdown
Member

thx @localvar

@xiangyu5632 xiangyu5632 merged commit 31819c2 into openGemini:main Apr 2, 2024
@localvar localvar deleted the fix-513 branch April 3, 2024 00:51
xiangyu5632 pushed a commit to xiangyu5632/openGemini that referenced this pull request Jul 27, 2024
Merge pull request openGemini#540 from TerryHowe/patch-1
0f44fe6 
Update ORAS maintainers
xuthus5 pushed a commit that referenced this pull request Mar 20, 2026
@localvar
fix: ts-cli command line argument 'precision' has no effect (#540)
0ad3dc5 
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangyu5632 xiangyu5632 xiangyu5632 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'ts-cli' command line argument 'precision' has no effect

2 participants

@localvar @xiangyu5632