Skip to content

fix: typo in 'show streams'#524

Merged
xiangyu5632 merged 2 commits into
openGemini:mainfrom
localvar:fix-show-streams
Apr 11, 2024
Merged

fix: typo in 'show streams'#524
xiangyu5632 merged 2 commits into
openGemini:mainfrom
localvar:fix-show-streams

Conversation

@localvar

@localvar localvar commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

the 'source measurement' should be database.retention policy.measurement, but was measurement.retention policy.measurement.

also fix several lint issues.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
  • Test cases to be added
  • No code

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@localvar

localvar commented Mar 7, 2024

Copy link
Copy Markdown
Contributor Author

pls help rerun the checks, the failure looks not related to my changes.

@xiangyu5632

Copy link
Copy Markdown
Member
image

@shilinlee is the go-generate version wrong?

@xiangyu5632

Copy link
Copy Markdown
Member

pls help rerun the checks, the failure looks not related to my changes.

the failure was fixed. pls update and commit again

@YarBor YarBor mentioned this pull request Apr 7, 2024
12 tasks
localvar added 2 commits April 8, 2024 09:47
the 'source measurement' should be `database`.`retention policy`.`measurement`, but was `measurement`.`retention policy`.`measurement`.

also fix several lint issues.

Signed-off-by: Bomin Zhang <localvar@hotmail.com>
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
@xiangyu5632 xiangyu5632 self-requested a review April 11, 2024 09:31
@xiangyu5632 xiangyu5632 merged commit dbba9c2 into openGemini:main Apr 11, 2024
@localvar localvar deleted the fix-show-streams branch April 12, 2024 02:09
Chenxulin97 pushed a commit to Chenxulin97/openGemini that referenced this pull request May 20, 2024
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
xiangyu5632 pushed a commit to xiangyu5632/openGemini that referenced this pull request Jul 27, 2024
doc: add Notary maintainers and update the reference link
xuthus5 pushed a commit that referenced this pull request Mar 20, 2026
Signed-off-by: Bomin Zhang <localvar@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants