fix: correct the compressor choose#801
Merged
Merged
Conversation
Signed-off-by: xkx <triumph_9431@qq.com>
Contributor
Author
|
@vicky-run @fx408 Please help review and merge this, I changed this from copilot code gen wrong. |
xuthus5
approved these changes
Nov 21, 2024
hezhangjian
requested changes
Nov 21, 2024
hezhangjian
left a comment
Member
There was a problem hiding this comment.
can we add some unit tests?
Signed-off-by: xkx <triumph_9431@qq.com>
fx408
approved these changes
Nov 21, 2024
xuthus5
pushed a commit
that referenced
this pull request
Mar 20, 2026
<!-- Thank you for contributing to openGemini! --> <!-- Mark the checkbox [X] or [x] if you agree with the item. --> ### What problem does this PR solve? <!-- Please create an issue first to describe the problem. There MUST be one line starting with "Issue Number: " and linking the relevant issues via the "close","fix", "resolve" or "ref". --> Issue Number: fix #791 ### What is changed and how it works? Prior to the PR, there were two issues: 1. We should use the HTTP header **Accept-Encoding** instead of content-encoding to determine the compressor. ## Todo - [ ] we also need to consider the content negotiation if http headers contains a list of accept encoding suits. ### How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] Unit Test - [x] Integration Test - [ ] Test cases to be added - [ ] No code ## validation  # Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules Signed-off-by: xkx <triumph_9431@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: fix #791
What is changed and how it works?
Prior to the PR, there were two issues:
Todo
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
validation
Checklist: