Skip to content

Villager ai callback (Partial implementation of #657) #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
FalseIlyu wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Villager ai callback (Partial implementation of #657) #659

FalseIlyu wants to merge 2 commits into from

Conversation

@FalseIlyu
Copy link
Contributor

@FalseIlyu FalseIlyu commented Aug 29, 2023 •
edited
Loading

This PR does two main things (related to #657).
1- changing entries so instead of using the one k_TodoEntry the callback used by each states use k_TodoEntry callbacks.
2- Implement a few of the simplest states (State function return 1, use the default field0x50 callback which is added in this PR)

  • MOVE_TO_FOOTBALL_PITCH_CONSTRUCTION
  • ARRIVES_IN_ABODE_TO_TRADE
  • ARRIVES_IN_ABODE_TO_PICK_UP_EXCESS
  • SITS_DOWN_TO_DINNER
  • WAIT_FOR_DINNER
  • HOMELESS_EAT_DINNER
  • EAT_OUTSIDE
  • VILLAGER_GOSSIPS
  • CHECK_INTERACT_WITH_POT
  • CHECK_INTERACT_WITH_ROCK
  • NOTHING_TO_DO

@FalseIlyu
Create a default callback for field0x50
df93da3 
Signed-off-by: FalseIlyu <ilyulemail@gmail.com>
@FalseIlyu
Defining simple states
5fdcb38 
Signed-off-by: FalseIlyu <ilyulemail@gmail.com>
@bwrsandman
Copy link
Member

bwrsandman commented Aug 31, 2023

Do you have video or logs of villagers going through these states?

@FalseIlyu
Copy link
Contributor Author

FalseIlyu commented Sep 1, 2023

Do you have video or logs of villagers going through these states?

No.
I don't think those states actually do anything and i didn't manage to have the villager go through any of them in game so for the same reason you asked to drop the callbacks maybe the better course is to remove such states.
However i think i would need to have more time to investigate before saying it for sure.

@bwrsandman bwrsandman added this to the 0.2.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@FalseIlyu @bwrsandman