-
Notifications
You must be signed in to change notification settings - Fork 77
Refactoring of the Renderer #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
862a618 to
68e830c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
2581a77 to
5b685be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
a9be85f to
2e5478e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
376bcbd to
aefff02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
a1f4b42 to
2625649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
2625649 to
c6d53bd
Compare
src/ECS/Components/Drawable.h
Outdated
| uint32_t count; | ||
| /* data */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clang-format] reported by reviewdog 🐶
| uint32_t count; | |
| /* data */ | |
| uint32_t count; | |
| /* data */ |
src/Game.cpp
Outdated
| { | ||
| auto section = profiler.BeginScoped(Profiler::Stage::SceneDraw); | ||
|
|
||
| std::set<graphics::Technique> drawPass{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clang-format] reported by reviewdog 🐶
| std::set<graphics::Technique> drawPass{}; | |
| std::set<graphics::Technique> drawPass {}; |
6a8ca3a to
a414b28
Compare
The motive of this PR is to break the big DrawPass function of the renderer, for this i decided to bring part of the function for instance
into its own function.
To organise all this i would have all subtask of a pass be declared in a enumeration (i call Technique, you have one to draw the sky, one to draw entities, etc...) that would be mapped to variation of a templated function (named renderTechnique) in a way not to dissimilar with how we handle shader you would have to declare the Technique in the manage, and add the mapping to the function. Right now you also need to declare the instanciation but i hope to find a better way.
The long term objective would be :