Add minimum supported Go version to CI #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On top of automatically testing against the two most recent releases (what Go upstream supports), also test explicitly against our lower bound. As noted in the previous change, don't have a `go.mod` to source this information from, so it's simply hard-coded in this file instead. (I chose 1.21 as that was the lowest version we were testing against previously, but it's possible that could go lower or actually reasonably needs to go higher.) Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
AkihiroSuda
reviewed
Oct 24, 2025
| matrix: | ||
| go: [oldstable, stable] | ||
| # our oldest (officially) supported version and the two upstream-supported versions | ||
| go: [1.21.x, oldstable, stable] |
There was a problem hiding this comment.
GOTOOLCHAIN=local is needed to avoid accidental auto upgrading
There was a problem hiding this comment.
True, good point, although we don't have a go.mod at all so it's a little bit moot for now, right?
AkihiroSuda
approved these changes
Oct 24, 2025
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
AkihiroSuda
approved these changes
Oct 24, 2025
utam0k
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of automatically testing against the two most recent releases (what Go upstream supports), also test explicitly against our lower bound.
As noted in the previous change, don't have a
go.modto source this information from, so it's simply hard-coded in this file instead.(I chose 1.21 as that was the lowest version we were testing against previously, but it's possible that could go lower or actually reasonably needs to go higher.)