Issue #1617: Twig - Flexibility to extend form select & submit, for extra classes + attributes #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mit, for extra classes + attributes
22Alexandra
reviewed
Jul 28, 2025
Contributor
22Alexandra
left a comment
There was a problem hiding this comment.
Thank you for the contribution, the changes will be done in #1630.
Comment on lines
-9
to
+11
| {% set extraAttributes = [] %} | ||
| {% set extra_attributes = extra_attributes|default([]) %} | ||
| {% for name,value in attributes %} | ||
| {% set extraAttributes = extraAttributes|merge([{'name': name, 'value': value}]) %} | ||
| {% set extra_attributes = extra_attributes|merge([{'name': name, 'value': value}]) %} |
Contributor
There was a problem hiding this comment.
These changes are not necessary because the way the template works now is passing the extraAttributes built from the existing attributes of the form element.
For example, these are the existing attributes of an element:
And these are the attributes rendered:
So, the desired extra attributes can safely be passed through the preprocess on the attributes array.
| label: attributes.value, | ||
| variant: variant|default('primary'), | ||
| extra_attributes: extraAttributes | ||
| extra_classes: extra_classes|default(''), |
Contributor
There was a problem hiding this comment.
Indeed, passing extra classes was missing. It's going to be fixed in #1630 and the extra classes can be passed through the preprocess on the class array of the attributes array.
Comment on lines
+67
to
+68
| extra_classes: extra_classes_input|default(''), | ||
| extra_attributes: extra_attributes_input|default([]), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1617
Description
Related to #1617 :: Twig - Flexibility to extend form select & submit, for extra classes + attributes
This a non breaking change proposal, so people would still have per project to extend the necessary and set those.
But on the long term, we should maybe force the
attributesandattributes.classvalues/content into the final form element by default, so things can work properly by default for new projects without the need to extend those templates.