Add create container for floating sidebar #1232
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for creating containers with floating sidebars in the maplibregl module. The changes introduce a conditional branch in the create_container method to handle floating sidebar creation separately from regular container sidebars.
- Adds conditional logic to check for floating sidebar flag
- Implements floating sidebar widget creation with configurable parameters
- Maintains backward compatibility with existing regular container sidebar functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| sidebar_visible = self.sidebar_args.get("sidebar_visible", False) | ||
| expanded = self.sidebar_args.get("expanded", True) | ||
| position = self.sidebar_args.get("position", "top-left") | ||
| width = self.sidebar_args.get("width", "370px") | ||
| max_height = self.sidebar_args.get("max_height", "80vh") | ||
| sidebar_content = self.sidebar_args.get("sidebar_content", None) |
There was a problem hiding this comment.
The parameter extraction logic is duplicated between the floating sidebar path and the regular sidebar path (lines 347-349). Consider extracting this common parameter retrieval logic into a helper method to reduce duplication and improve maintainability.
|
🚀 Deployed on https://68f2df0f6870f14eac8e4441--opengeos.netlify.app |
|
Thanks for the contribution @giswqs 🤩 |
No description provided.