Watch: Expand lists #1025
Watch: Expand lists #1025
Conversation
Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR implements list expansion functionality for the watchOS app by refactoring the navigation architecture to support nested pages. The changes enable users to navigate from a sitemap page into linked pages (sub-lists) within the watch interface.
Key Changes:
- Refactored SitemapPageView to conditionally render NavigationStack only at the root level, avoiding nested NavigationStack issues
- Added a new UserData initializer that accepts a linkedPage parameter for loading sub-pages
- Replaced NavigationLink wrapping in OpenHABWidgetExtension with a simple chevron indicator, moving navigation logic to WidgetRowView
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openHABWatch/Views/SitemapPageView.swift | Refactored to support nested navigation with conditional NavigationStack and new WidgetRowView wrapper for handling linked page navigation |
| openHABWatch/Domain/UserData.swift | Added init(linkedPage:) to enable loading sub-pages for navigation |
| openHABWatch/Model/OpenHABWidgetExtension.swift | Simplified makeView to only display chevron icon, removing NavigationLink logic |
| openHABWatch/Views/Utils/IconView.swift | Commented out success logging to reduce log verbosity |
| OpenHABCore/Sources/OpenHABCore/Util/Endpoint.swift | Commented out debug URL logging to reduce log verbosity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
Signed-off-by: Tim Bert <5411131+timbms@users.noreply.github.com>
|
Wow, what a surprise. Many thanks for that "early Christmas present". Quite keen to try it out and to make use of it for my watch sitemap. Wish you guys a merry Chrismas season and again thanks a lot for all the effort you've put this year into the (now) really great iOS app. |
|
@curlyel Thank you for your kind words. Please put a good review on App Store. This helps to promote the openHAB project over all. |
Done. But for whatever reason the review is not (yet?) visible to me. |
Fix #982