Skip to content

[WIP] Upgrade PodUnavailableBudget from v1alpha1 to v1beta1 #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PersistentJZH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Upgrade PodUnavailableBudget from v1alpha1 to v1beta1 #2236

PersistentJZH wants to merge 1 commit into from

Conversation

@PersistentJZH
Copy link
Contributor

@PersistentJZH PersistentJZH commented Nov 14, 2025

Ⅰ. Describe what this PR does

upgrade PodUnavailableBudget from v1alpha1 to v1beta1

  • annotation kruise.io/pub-protect-operations to protectOperations
  • annotation pub.kruise.io/protect-total-replicas to protectTotalReplicas

Ⅱ. Does this pull request fix one issue?

#2122

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

kruise-bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PersistentJZH
Upgrade PodUnavailableBudget from v1alpha1 to v1beta1
f45b836 
Signed-off-by: PersistentJZH <zhihao.kan17@gmail.com>
@PersistentJZH PersistentJZH force-pushed the feat/upgrade-kruise-apis-to-v1beta1-phrase-6 branch from b8efadc to f45b836 Compare November 14, 2025 14:39
@codecov
Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 3.81679% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.66%. Comparing base (ad9987b) to head (f45b836).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ablebudget/validating/pub_create_update_handler.go 5.05% 94 Missing ⚠️
pkg/control/pubcontrol/pub_control.go 0.00% 32 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2236      +/-   ##
==========================================
- Coverage   47.88%   47.66%   -0.22%     
==========================================
  Files         324      324              
  Lines       27520    27647     +127     
==========================================
+ Hits        13178    13179       +1     
- Misses      12847    12973     +126     
  Partials     1495     1495
Flag Coverage Δ
unittests 47.66% <3.81%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PersistentJZH PersistentJZH mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@furykerry furykerry Awaiting requested review from furykerry

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/work-in-progress size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PersistentJZH @kruise-bot