This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Rails 5 support and deprecation fixes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icity_token has not been defined" error in Rails 5. Such error should be silenced. See more: rails/rails#19029
…to fix deprecation message in Rails 5: DEPRECATION WARNING: env is deprecated and will be removed from Rails 5.1 (called from oauth_client_can_write? at /lib/opro/controllers/concerns/permissions.rb:58)
…ixing failing tests, deprecations and updating config files.
Author
|
Tests are passing for me locally with ruby 2.3 and Rails 5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 related fixes added:
ArgumentError: Before process_action callback :verify_authenticity_token has not been defined.before_filterwithbefore_action.around_filterwitharound_action.skip_before_filterwithskip_before_action.prepend_before_filterwithprepend_before_action.request.env['REQUEST_METHOD']instead ofenv['REQUEST_METHOD']to fix deprecation message.Also I bumped dummy app to rails 5 version in order for tests to pass. In order to do that I also had to bump devise to "4.3.0"
Those changes will not work with apps using Rails 3.