Add manifest tests #1884
Open
Add manifest tests #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lob* handlers (oras-project#1861) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TerryHowe <104113+TerryHowe@users.noreply.github.com> Co-authored-by: shizhMSFT <32161882+shizhMSFT@users.noreply.github.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: ManishhDev <codermanishhh@gmail.com>
…lob* handlers (oras-project#1861) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TerryHowe <104113+TerryHowe@users.noreply.github.com> Co-authored-by: shizhMSFT <32161882+shizhMSFT@users.noreply.github.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: ManishhDev <codermanishhh@gmail.com>
Signed-off-by: ManishhDev <codermanishhh@gmail.com>
|
Hi, |
wangxiaoxuan273
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1863 by adding comprehensive unit test coverage for three previously untested manifest handler modules. The tests verify the core functionality of manifest deletion, index creation, and manifest push operations.
Key Changes:
- Added test coverage for ManifestDeleteHandler with tests for OnManifestMissing and OnManifestDeleted methods
- Added test coverage for ManifestIndexCreateHandler with tests for OnTagged, OnIndexCreated, and Render methods
- Added test coverage for ManifestPushHandler with tests for OnTagged, OnManifestPushed, and Render methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/oras/internal/display/metadata/text/manifest_delete_test.go | Implements unit tests for manifest deletion handler methods and constructor |
| cmd/oras/internal/display/metadata/text/manifest_index_test.go | Implements unit tests for manifest index creation handler methods and constructor |
| cmd/oras/internal/display/metadata/text/manifest_push_test.go | Implements unit tests for manifest push handler methods and constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Ignore those copilot comments. That looks like the given-when-then pattern to me pretty much. |
|
Something wrong with the build, see the logs, but a sample: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1863
Added unit tests for manifest_delete.go, manifest_index.go and manifest_push.go. These were missing test coverage so I wrote tests covering all the main methods in each handler.
Tests include:
What this PR does / why we need it:
Adds missing test coverage for the manifest handlers to help catch bugs and make the code more reliable.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1863
Please check the following list: