test(e2e): add E2E testing utilities and sample specs #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Nov 8, 2022
| trap 'docker kill oras-e2e || true' ERR | ||
| docker run -d -p 5000:5000 --rm --name oras-e2e \ | ||
| --env STORAGE_DELETE_ENABLED=true \ | ||
| docker run --pull always -d -p 5000:5000 --rm --name oras-e2e \ |
There was a problem hiding this comment.
Do we need to --pull always?
There was a problem hiding this comment.
The default behavior is missing, which can be wrong if github provided an uncleaned VM. always is more defensive.
| --env REGISTRY_AUTH_HTPASSWD_REALM=test-basic \ | ||
| --env REGISTRY_AUTH_HTPASSWD_PATH=/etc/docker/registry/passwd \ | ||
| --mount type=bind,source=$mnt_root/docker,target=/opt/data/registry-root-dir/docker \ | ||
| --mount type=bind,source=$mnt_root/passwd_bcrypt,target=/etc/docker/registry/passwd \ |
There was a problem hiding this comment.
Can we generate passwd file on the fly? I have concerns that security checkers will scan the repo and find we are storing credentials.
There was a problem hiding this comment.
It's doable but will complicate the setup. Can we set this aside and consider the design in another issue #680 with configurable username/password/token?
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Nov 9, 2022
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
This PR includes below changes in the E2E utility package: 1. Enables basic auth in test infra 2. Supports excuting oras or other binaries with fluent-styled runtime configuring and result matching 3. Introduces `match` packages to validate execution results 4. Added sample test specs for `manifest fetch` command and common OCI image scenario. Resolves oras-project#554, resolves oras-project#555, resolves oras-project#556, resolves oras-project#565 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes below changes in the E2E utility package:
matchpackages to validate execution resultsmanifest fetchcommand and common OCI image scenario.Resolves #554, resolves #555, resolves #556, resolves #565