Skip to content

Conversation

@doudou
Copy link
Contributor

@doudou doudou commented Jun 14, 2014

This does some spring cleaning on Utilrb

  • remove some deprecated /barely working / totally unused code
  • remove 1.8 compatibility code
  • port to minitest. Ruby is bundling minitest as the test library, with a "shim" to make it compatible with Test::Unit. Unfortunately, this shim is broken if the minitest gem gets installed. The most robust option is to simply use Minitest directly.
  • remove warnings issued by -w (not all warnings are fixed, only the most straightforward ones)

doudou added 8 commits June 14, 2014 14:45
modern Ruby VMs have much better alternatives
It got extracted as metaruby and is unmaintained
define_finalizer is now (on ruby 2.1) raising RuntimeError
(instead of ArgumentError) in this case. Catch and re-raise
ArgumentEror
Ruby's bundled minitest version and the gem are out of sync (in general),
which makes Test::Unit break. Simply port to minitest, and while I am
at it use a common template for test setup (from Rock's ruby library
template)
The test block moved, so we need to update the lines
doudou added a commit that referenced this pull request Aug 1, 2014
@doudou doudou merged commit 044d1b0 into master Aug 1, 2014
@doudou doudou deleted the spring_cleanup branch August 1, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants