perf: improve hash injectivity constraints#406
Merged
Conversation
0xkarmacoma
reviewed
Nov 13, 2024
Comment on lines
+116
to
+117
| # TODO: explore the impact of using a smaller bitsize for the range sort | ||
| f_inv_sha3_size = Function("f_inv_sha3_size", BitVecSort256, BitVecSort256) |
Contributor
There was a problem hiding this comment.
BitVecSort32 should work for the input size, right?
Collaborator
Author
There was a problem hiding this comment.
does the max size of byte arrays that can appear during execution not exceed 2^32 bits (2^29 bytes)? if so, yes.
Contributor
There was a problem hiding this comment.
that's definitely not realistic in the current EVM execution context. 2^20 is already huge (1MB)
0xkarmacoma
approved these changes
Nov 13, 2024
0xkarmacoma
left a comment
Contributor
There was a problem hiding this comment.
very nice! excited to give it a try. I can see this helping with storage-heavy tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we formulated the hash injectivity axiom as
hash(x) == hash(y) ==> x == y, which required generating local constraints for all combinations of hash inputs, resulting in O(n^2).Now, we reformulate the injectivity axiom as "there exists f, such that
f(hash(x)) == x," which requires only O(n) constraints, each of which is independent from other constraints.