refactor: custom VM support #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncitron
requested changes
Jun 9, 2025
Collaborator
ncitron
left a comment
There was a problem hiding this comment.
Looks very good. Just a few small comments.
7c8ab35 to
88bb149
Compare
Contributor
Author
|
should be gtg, for some reason the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #406
Description
This PR adds new method on the
network_spec:transactthat basically replays/process a tx in a VM. This changes decouples the execution from the generic EVM interface, allowing each network to define its own EVM implementation.Note
execution_providerwas moved to common crate from core, for use withinnetwork_spectx_envandblock_envmethod for that network. Minimal code repetition approach followed, but still scope of improvement if we are able to implement ProofDB properly.Old PRs closed due to major codebase refactoring #597 #502