fix: remove spawn_blocking for payload_to_block conversions#636
Merged
Conversation
Removed the use of tokio::task::spawn_blocking for payload_to_block conversions in the consensus module. The payload_to_block function is now called directly instead of being wrapped in spawn_blocking tasks. This fixes WASM compatibility issues since spawn_blocking is not supported in WASM environments. Also includes a minor formatting fix in helios-ts/index.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Context
The
tokio::task::spawn_blockingfunction is designed to move CPU-intensive work off the async runtime to dedicated threads. However, this functionality is not available in WASM environments which don't have access to OS-level threads. By removing these spawn_blocking calls, the code now works correctly in both native and WASM builds.