fix(save_manager): traverse remote folders with recursion#42
Merged
Conversation
Owner
|
Even if I can't test this currently, this looks good to me. Thanks for the contribution! |
This was referenced Oct 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this pull request you should be able to backup any folder from the switch regardles of the folder structure, even if heavily nested.
Fixes #41 and should also fix #18 and #23
Motivations:
Most games don't have a convention for folder structure on save data, making it impossible to guess how deep you have too look for save files.
Solution:
Traverse the folders with recursion while checking if it's a file and keeping track of current path and it's children. It also ignores empty foldes.
How has this been tested?
Tested with the following
shop_config.tml:Console output: