Skip to content

gitlog doesn't work with dynamically generated classes #1

Open

Description

@eywalker

It appears that gitlog cannot be applied to dynamically generated classes, likely due to file path issue.

Activity

  1. eywalker commented on Mar 12, 2017

    @eywalker
    MemberAuthor

    As I suspected, this is triggered by the fact that the decorator inspects the class to discover the name of the file in which the class is defined. When used on dynamically generated class, this returns a path to a temporary file which is naturally part of a Git repo. It would make sense for gitlog to take in an optional argument that can directly specify path that is part of a Git repo (e.g. passing in __file__ from the context in which the class is dynamically generated). This also has the benefit of allowing the user to link the table class to be linked to an arbitrary Git repo of choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions