Fix Internal _mantissa problem on WASI#132
Open
KINGH242 wants to merge 1 commit into
Open
Conversation
On WASI, `Decimal` comes from FoundationEssentials where `_mantissa` has internal access, the same situation as Linux/Android/Windows. Add `os(WASI)` to the exclusion gates so the string-based significand path is used and `mantissaParts` is not compiled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On WASI,
Decimalis provided by FoundationEssentials, where_mantissahas
internalaccess — the same situation that PR #125 addressed forWindows and that the original guard handled for Linux/Android.
Without this change, BigInt fails to build for the
wasm32-unknown-wasip1SDK