Skip to content

Refactor PromptRendering handling #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramya18101 merged 13 commits into from
Nov 19, 2025
Merged

Refactor PromptRendering handling #594

ramya18101 merged 13 commits into from
Nov 19, 2025

Conversation

@ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Aug 25, 2025 •
edited by developerkunal
Loading

🔧 Changes

  • Removed custom MarshalJSON method from PromptRendering, relying on default JSON marshaling.
  • Updated cleanForPatch to always return a fully populated struct for consistency in patch operations.

📚 References

🔬 Testing

  • Strengthened TestPromptManager_ListRendering with assertions for Screen and Prompt field equality.
  • Enhanced givenAPromptRendering helper to re-fetch and validate settings after updates.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ramya18101
Copy link
Contributor Author

ramya18101 commented Aug 25, 2025

Yet to re-record the tests!

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.69%. Comparing base (de64b9c) to head (b53d1e0).

Files with missing lines Patch % Lines
management/prompt.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               v1     #594      +/-   ##
==========================================
- Coverage   96.71%   96.69%   -0.02%     
==========================================
  Files          62       62              
  Lines       10736    10742       +6     
==========================================
+ Hits        10383    10387       +4     
- Misses        235      236       +1     
- Partials      118      119       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ramya18101 ramya18101 marked this pull request as ready for review September 3, 2025 14:39
@ramya18101 ramya18101 requested a review from a team as a code owner September 3, 2025 14:39
developerkunal
developerkunal reviewed Sep 8, 2025
View reviewed changes
@ramya18101 ramya18101 changed the title Refactor PromptRendering handling [Don't Merge] Refactor PromptRendering handling Sep 8, 2025
developerkunal
developerkunal reviewed Sep 8, 2025
View reviewed changes
developerkunal
developerkunal reviewed Sep 8, 2025
View reviewed changes
duedares-rvj
duedares-rvj reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@duedares-rvj duedares-rvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramya18101 ramya18101 self-assigned this Oct 13, 2025
@developerkunal developerkunal changed the base branch from main to v1 October 14, 2025 19:09
@ramya18101 ramya18101 changed the title [Don't Merge] Refactor PromptRendering handling Refactor PromptRendering handling Nov 17, 2025
developerkunal
developerkunal approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramya18101 ramya18101 merged commit 32b5832 into v1 Nov 19, 2025
4 checks passed
@ramya18101 ramya18101 deleted the Expose-prompt-and-screen-info-in-list-rendering branch November 19, 2025 07:30
@developerkunal developerkunal mentioned this pull request Nov 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duedares-rvj duedares-rvj duedares-rvj left review comments

@developerkunal developerkunal developerkunal approved these changes

@kushalshit27 kushalshit27 kushalshit27 approved these changes

Assignees

@ramya18101 ramya18101

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ramya18101 @codecov-commenter @duedares-rvj @developerkunal @kushalshit27