Update conc_parent logic to check if we really want "none" as a parent #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting some of the changes black did, but the checks aren't liking.
codybanman
requested changes
Sep 22, 2025
Contributor
codybanman
left a comment
There was a problem hiding this comment.
Looks great! Could you rebase the branch onto nightly and update the ieffect section in docs/automation_ref.rst to describe the new behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In certain cases when casting spell automations, if an effect is applied to a target with no parent set, it will default to the conc_parent. This is giving user's the option to set the parent node to "none", and have the conc_parent be ignored.
Changelog Entry
Allow for "none" to be set in the ieffect parent
Checklist
PR Type
Other