Skip to content

chore: stop committing dist/ and remove bower#10747

Merged
jasonsaayman merged 4 commits into
axios:v0.xfrom
shaanmajid:chore/remove-committed-dist-v0x
Apr 18, 2026
Merged

chore: stop committing dist/ and remove bower#10747
jasonsaayman merged 4 commits into
axios:v0.xfrom
shaanmajid:chore/remove-committed-dist-v0x

Conversation

@shaanmajid
Copy link
Copy Markdown
Contributor

@shaanmajid shaanmajid commented Apr 18, 2026

Stops committing built dist/ artifacts on v0.x, mirroring #7002 on v1.x. CI builds dist before tests and publish, so npm consumers are unaffected. Bower removal is bundled in here because bower installs directly from the git tree, so dropping committed dist/ would otherwise break bower install axios; on v1.x this cleanup lives in a separate PR (#10746). Bower has been deprecated since 2017 with its last release in 2021, so coupling the two changes is low risk.


Summary by cubic

Stop committing built artifacts in dist/ on v0.x and remove bower support. Keeps the repo clean and avoids stale bundles; npm installs are unaffected.

Description

  • Summary of changes

    • Add dist/ to .gitignore; remove committed dist/ files.
    • Remove bower.json and the Grunt package2bower task.
    • Update docs to drop bower instructions and adjust AMD example path.
    • Clean up .npmignore and CONTRIBUTING.md.
  • Reasoning

    • CI builds bundles before tests and publish, so npm consumers are unaffected.
    • bower installs from the git tree; without committed dist/ it would break, so we remove bower.
    • bower is deprecated; users should use npm/yarn/pnpm or a CDN.
  • Additional context

    • Aligns v0.x with the v1.x workflow.
    • If you installed via bower or from git, switch to npm or a CDN.

Docs

  • README: remove bower install section.
  • UPGRADE_GUIDE: update AMD example to use require(['axios/dist/axios']).
  • CONTRIBUTING: remove outdated note about committing dist/.

Testing

  • No test changes.
  • No new tests needed; this is build/doc-only.
  • CI already builds bundles before tests/publish; ensure release artifacts still include dist/ as part of the publish step.

Written for commit 65574e5. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@jasonsaayman jasonsaayman added priority::medium A medium priority commit::chore The PR is related to a chore labels Apr 18, 2026
@jasonsaayman jasonsaayman merged commit f4f2d76 into axios:v0.x Apr 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::chore The PR is related to a chore priority::medium A medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants