Skip to content

fix: remove all caches#10882

Merged
jasonsaayman merged 1 commit into
v1.xfrom
fix/remove-all-caches-from-actions
May 12, 2026
Merged

fix: remove all caches#10882
jasonsaayman merged 1 commit into
v1.xfrom
fix/remove-all-caches-from-actions

Conversation

@jasonsaayman
Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman commented May 12, 2026

Summary by cubic

Disable all package manager caches in GitHub Actions to improve build reproducibility and eliminate flaky CI due to stale caches. Also standardizes the npm registry configuration and disables Bun/Deno caches.

  • Changes

    • Remove cache: npm and cache-dependency-path from all actions/setup-node steps.
    • Set registry-url: 'https://registry.npmjs.org' and package-manager-cache: false for all Node jobs.
    • Add no-cache: true to oven-sh/setup-bun and cache: false to denoland/setup-deno.
    • Update lockfile-lint to use the npm registry without caching.
    • Minor workflow cleanups: clearer step names and consistent install/build/test order.
  • Notes

    • Docs: Suggest updating /docs/ci.md (or equivalent) to state that CI caching is disabled for reproducibility, and initial installs may be slower.
    • Testing: No code tests changed. CI already runs unit, browser, smoke, and module tests across environments; this validates the change.
    • Semantic version impact: None. CI-only changes; no package release required.

Written for commit 5e0ceed. Summary will update on new commits.

@jasonsaayman jasonsaayman self-assigned this May 12, 2026
@jasonsaayman jasonsaayman added priority::medium A medium priority commit::fix The PR is related to a bugfix labels May 12, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Confidence score: 2/5

  • There is a high-confidence workflow bug in .github/workflows/moderator.yml: placing name as a standalone step instead of alongside uses can make the job definition invalid and prevent the workflow from running correctly.
  • This drives the score down because it is a concrete, user-impacting CI regression risk (severity 8/10, confidence 10/10), even though the fix should be straightforward.
  • Pay close attention to .github/workflows/moderator.yml - step structure needs correction so name is attached to the same step as uses.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/moderator.yml">

<violation number="1" location=".github/workflows/moderator.yml:19">
P1: Move the `name` key onto the same step as `uses`; the current YAML creates invalid standalone steps.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

models: read
contents: read
steps:
- name: Checkout repo
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Move the name key onto the same step as uses; the current YAML creates invalid standalone steps.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/moderator.yml, line 19:

<comment>Move the `name` key onto the same step as `uses`; the current YAML creates invalid standalone steps.</comment>

<file context>
@@ -16,9 +16,12 @@ jobs:
       models: read
       contents: read
     steps:
+      - name: Checkout repo
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
</file context>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #10887.

@jasonsaayman jasonsaayman merged commit 858a790 into v1.x May 12, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::fix The PR is related to a bugfix priority::medium A medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants