Fixes #5 #6
Merged
Merged
Conversation
Uppdated CSS to not block the input text-area
Member
|
I think it would be better to just skip the isinstance int on L283 and cast the ttl value as an integer |
Contributor
Author
Agreed, keeping that change. TTL is now cast to int, error forwarded to user if something goes wrong. Combined nested if statements as suggested. I was thinking, should we handle negative ttl values as well? |
Member
You could try something like: try:
ttl = int(request_body["ttl"])
if ttl <= 0:
raise ValueError("The number must be a positive integer.")
except ValueError as e:
print(e) |
Member
|
Looks good, we try for a Friday merge! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5 by converting the expected string to an integer.
Reset to default TTL when encountering reasonable exceptions.
Log exception and reset to default TTL when encountering unexpected exceptions.