Use property getter instead of irGetField in replaceByRegexp#82
Merged
Conversation
aa83397 to
b8e9235
Compare
Direct backing field access bypasses property accessors and is inconsistent with maskPropertiesInToStringFunction which already uses irCall(property.getter!!.symbol). A local propertyValue() lambda avoids repeating the getter call expression three times. Closes #69 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b8e9235 to
76ecea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceByRegexpwas usingirGetField(...)to read property values directly from the backing field, whilemaskPropertiesInToStringFunction(the other branch of the same logic) usesirCall(property.getter!!.symbol).Direct field access bypasses property accessors and would produce incorrect results for properties with custom getters.
Fix: replace all three
irGetFieldusages with getter calls via a localpropertyValue()lambda, consistent with the rest of the transformer.Closes #69