AbacusHOD: Moving mock dir creation to run_hod
#187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid creating empty folder)
… and return an explicit error otherwise to avoid an "out of range" IndexError instead
…ory one, to make the raised error understandable)
for more information, see https://pre-commit.ci
run_hodrun_hod
Member
|
Thanks @SBouchard01! I agree we should fix this. Do you think we could just move the |
Contributor
Author
|
From what I see we could even remove it, as |
Member
|
Good point. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
mkdiris called in staging, it creates empty directories all over the place when runningAbacusHODon the fly (which I have to do as the amount of BGS mocks I create is too big to keep on disk)I moved it to
run_hodand added a condition onwrite_to_diskto ensure empty folders are not created.Also, I added two
FileNotFoundErrorinstagingbecause the errors raised in those case were not really understandable ( e.g. anIndexError)Overall behavior should in theory be unchanged 👍🏼