Add support for custom enum as sketch parameter#107
Merged
Conversation
TODO: - better UI - handle "simple" enum (no collapsing, grid true) - handle `self` (how???) - clean code
TODO: - proper formatting of identifiers - handle `self` (how???) - clean code
TODO: - handle `self` (how???) - clean code
TODO: - handle `self` (how???) - clean code
TODO: - handle `param`!!!! - handle `self` (how???) - clean code
TODO: - handle `skip`!!!! - handle `self` (how???) - clean code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom enum to be used as sketch parameter, via the same
Widgetderive macro and#[sketch_widget]helper attribute.The generated code distinguishes two cases:
The former are displayed as a simple label + combo box that align to the UI grid. The latter offer a hierarchical UI that displays UI for nested data.
The
ui_demo.rsexample is updated to showcase the change.Limitations
selfto refer to another field in a#[param]attribute is not possible with enum fields.whiskers-derivecrate code is getting uglier and uglier.The UI for complex-enum empty variant is not very nice.