Conversation
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
free(3) the deprecation, sunset and link header values we get back from curl after inserting them into the result JSON. Handle them like we do for x_corr_id. Fixes: 56aad55 ("Flow some extra response headers from HMRC through") Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
When the API scope is MTD_API_SCOPE_NULL api_default_values[]->api_version (and ->api_name) will be NULL. Passing NULL to snprintf(3) et al is undefined behaviour, we were lucky in that we were getting "(null)" rather than a segfault. In these cases we don't need to set api_ver_hdr as we don't set the "Accept" header for "/oauth/token" urls. Fixes: ab39737 ("This is basically a new version") Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.