radius: Implement DM/CoA security hardening by restricting source ips #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements security hardening for RADIUS DM/CoA (Dynamic Authorization Extension / Change of Authorization) by restricting which source IP addresses are allowed to send DM/CoA requests. This addresses a security concern where any host knowing the shared secret could send DM/CoA requests to disconnect or modify sessions.
Key changes:
- Adds
dae-allowedconfiguration option to specify allowed source IPs/CIDR ranges - Implements source IP validation in the DM/CoA packet handler
- Provides deprecation warnings when DAE is configured without source restrictions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| accel-pppd/radius/radius_p.h | Adds function declaration for rad_dae_src_allowed and removes trailing blank line |
| accel-pppd/radius/radius.c | Implements IP range parsing, storage, and validation logic for DAE source restrictions |
| accel-pppd/radius/dm_coa.c | Adds source IP validation check before processing DM/CoA requests |
| accel-pppd/accel-ppp.conf.5 | Documents the new dae-allowed configuration option |
| accel-pppd/accel-ppp.conf | Adds commented example of dae-allowed configuration |
| README | Adds note about using dae-allowed for DM/CoA deployments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…addresses Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
fa93231 to
2550fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.