Skip to content

[LINST] fix survey and date issues #8858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 3 commits into from
Dec 12, 2023
Merged

[LINST] fix survey and date issues #8858

driusan merged 3 commits into from
Dec 12, 2023

Conversation

@ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Aug 9, 2023 •
edited
Loading

@zaliqarosli some changes derived from the QPN overrides that I believe apply to LORIS

  • add fields to XIN validation which are not parts of groups

@charliehenrib charliehenrib self-assigned this Aug 10, 2023
@laemtl laemtl self-assigned this Aug 10, 2023
@laemtl
Copy link
Contributor

laemtl commented Aug 10, 2023

Code looks good.

ridz1208
ridz1208 commented Aug 10, 2023
View reviewed changes
php/libraries/NDB_BVL_Instrument_LINST.class.inc Outdated
);

if (strrpos($this->testName ?? '', '_proband') === false) {
if (strrpos($this->testName ?? '', '_proband') === false
Copy link
Collaborator Author

@ridz1208 ridz1208 Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving this up

@charliehenrib charliehenrib added the State: Needs work PR awaiting additional work by the author to proceed label Aug 10, 2023
@ridz1208 ridz1208 removed the State: Needs work PR awaiting additional work by the author to proceed label Aug 10, 2023
@ridz1208
Copy link
Collaborator Author

ridz1208 commented Aug 10, 2023

@CamilleBeau @charliehenrib @laemtl

removed the change relating to age on direct instruments, I'll make a PR just for that

for the remaining changes I think what needs to be tested is to have a LINST instruments with 3 different types of dates Date, BasicDate and MonthYear (date types are defined as the 6th parameter of the date LINST element) also make sure to add some rules in the instrument.rules file and try it with and without this PR.

@driusan driusan merged commit bffcae3 into aces:24.1-release Dec 12, 2023
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaliqarosli zaliqarosli zaliqarosli approved these changes

Assignees

@driusan driusan

Labels

None yet

Projects

None yet

Milestone

24.1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@ridz1208 @laemtl @zaliqarosli @driusan @charliehenrib