Skip to content

[JSX] Modal Width Prop #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 1 commit into from
Dec 12, 2023
Merged

[JSX] Modal Width Prop #8893

driusan merged 1 commit into from
Dec 12, 2023

Conversation

@skarya22
Copy link
Contributor

@skarya22 skarya22 commented Sep 25, 2023

Brief summary of changes

  • Adds a width prop to Modal so that it can be changed from the default 700px
  • This exists in the main branch, but was not added to v24 for some reason
  • This would be used in CCNA v24.1 upgrade, and would also be useful for any other projects on 24 that use modals

Testing instructions (if applicable)

  1. Add the width prop to a modal such as width={'1000px'} and see if the modal is larger than before

@skarya22 skarya22 changed the base branch from main to 24.1-release September 25, 2023 19:39
@driusan driusan merged commit 6b67272 into aces:24.1-release Dec 12, 2023
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shonibare shonibare shonibare approved these changes

Assignees

@shonibare shonibare

Labels

None yet

Projects

None yet

Milestone

24.1.6

Development

Successfully merging this pull request may close these issues.

4 participants

@skarya22 @shonibare @driusan @ridz1208