[my_preference] Add support for my_preference widgets #8938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@driusan Should we fix the tests? |
laemtl
reviewed
Jan 16, 2024
| * Renders the widget within a preference panel and implements | ||
| * the \LORIS\GUI\Widget interface. | ||
| * | ||
| * @return string the HTML content of the widget to be rendered |
Contributor
There was a problem hiding this comment.
It seems to return an url, not html.
laemtl
approved these changes
Jan 16, 2024
This adds a new widget type, "userpreference" which allows modules to plug content into the user's my_preferences page.
7132a85 to
b99b837
Compare
Collaborator
Author
|
Fixed tests and comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new widget type, "userpreference" which allows modules to plug content into the user's my_preferences page.
It works similarly to the candidate_profile widget, where it assumes each call will return an array of UserPreferenceWidget's to add to the page, each one denoting a single react component. The UserPreferenceWidget must have:
This is useful for ie. the OIDC module adding a widget where the user can link an external openid account to the logged in user, but can also be used for any other modules which have preferences that should be configurable by the user on the my_preferences page.