Skip to content

Conversation

@CamilleBeau
Copy link
Collaborator

Brief summary of changes

This PR changes the query for the behavioural feedback tab of the Behavioural QC module to use "LEFT JOIN" instead of "JOIN" on visit specific tables so that profile level feedbacks that do not relate to any visit will be displayed.

COALESCE function is used for the project and site fields to take the visit project / site if it exists, and the candidate project / site otherwise.

The link to the profile is also added in the feedback level column.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Add a profile level feedback as well as a visit level feedback
  2. Go to the Behavioural QC module feedback tab
  3. Make sure the feedbacks are displayed in the filterable datatable
  4. Try filtering for the feedback and make sure it works (including site / project filter)
  5. Try clicking the link to go to the profile, make sure it takes you to the right candidate visit list

Link(s) to related issue(s)

@driusan
Copy link
Collaborator

driusan commented Apr 4, 2024

@CamilleBeau This has conflicts in the changelog

@CamilleBeau
Copy link
Collaborator Author

@driusan resolved!

@nicolasbrossard nicolasbrossard self-assigned this Apr 11, 2024
@nicolasbrossard nicolasbrossard added Passed manual tests PR has been successfully tested by at least one peer 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Apr 11, 2024
Copy link
Contributor

@nicolasbrossard nicolasbrossard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks code and PR works as expected on my VM. Approving.

@driusan driusan merged commit 23dbe45 into aces:main Apr 11, 2024
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[behavioural_qc] New Profile-level feedback not showing up in the Feedback table

4 participants