[Optmization] Replace bulkLoadInstanceData with generator #9347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Blocked by #9344 (as it uses getNewDatabaseConnection) |
driusan
commented
Sep 23, 2024
| * | ||
| * @param $commentIDs string[] A list of commentIDs to load in bulk. | ||
| * | ||
| * @return \NDB_BVL_Instrument[] |
Collaborator
Author
There was a problem hiding this comment.
This type shouldn't have to change but phan isn't great at understanding generators and doesn't recognize them as sometype[] compatible.
faebee7 to
14e9352
Compare
BulkLoadInstanceData currently returns an array of instruments for each candidate. This is inefficient because every instrument needs to be loaded into memory, when the results are only ever used in a foreach loop. This replaces the array_map with a generator that yields the instrument, and uses an unbuffered database connection. This uses significantly less memory for large datasets as now only one CommentID needs to be loaded into memory at a time.
14e9352 to
13397fa
Compare
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
BulkLoadInstanceData currently returns an array of instruments for each candidate. This is inefficient because every instrument needs to be loaded into memory, when the results are only ever used in a foreach loop. This replaces the array_map with a generator that yields the instrument, and uses an unbuffered database connection. This uses significantly less memory for large datasets as now only one CommentID needs to be loaded into memory at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkLoadInstanceData currently returns an array of instruments for each candidate. This is inefficient because every instrument needs to be loaded into memory, when the results are only ever used in a foreach loop. This replaces the array_map with a generator that yields the instrument, and uses an unbuffered database connection.
This uses significantly less memory for large datasets as now only one CommentID needs to be loaded into memory at a time.