[Utility] Remove unnecessary joins in queries #9369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were (at least) 2 unnecessaries joins in database queries in getVisitList and getVisitInstruments where a table was joined, and then the table was only used to filter for the same key that was used in the join condition. Remove those joins by just filtering on the key in the first place.
maximemulder
approved these changes
Oct 28, 2024
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
There were (at least) 2 unnecessaries joins in database queries in getVisitList and getVisitInstruments where a table was joined, and then the table was only used to filter for the same key that was used in the join condition. Remove those joins by just filtering on the key in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were (at least) 2 unnecessaries joins in database queries in getVisitList and getVisitInstruments where a table was joined, and then the table was only used to filter for the same key that was used in the join condition.
Remove those joins by just filtering on the key in the first place.