Skip to content

[Survey Module] Update survey status upon data_entry #9441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 3 commits into from
Nov 26, 2024
Merged

[Survey Module] Update survey status upon data_entry #9441

driusan merged 3 commits into from
Nov 26, 2024

Conversation

@victori444
Copy link
Contributor

@victori444 victori444 commented Oct 31, 2024 •
edited
Loading

Brief summary of changes

When an instrument's data entry is updated to In Progress/Complete, the Status field in participant_accounts is also updated accordingly

Testing instructions (if applicable)

  1. In the survey accounts module, add a new survey for an instrument for which isDirectEntry = 1
  2. Change the data entry status directly in the candidate's instrument page
  3. Check that the status in participant_accounts / in the survey accounts table is also updated to the correct value

CCNA Override

@victori444 victori444 added Priority: Projects State: Needs work PR awaiting additional work by the author to proceed labels Oct 31, 2024
@kongtiaowang
Copy link
Contributor

kongtiaowang commented Nov 4, 2024

https://github.com/kongtiaowang/Loris/pull/413/files
Adding the participant_accounts table it the setUp() and tearDown () It will pass the test, since the Status field in participant_accounts is updated accordingly.

@CamilleBeau CamilleBeau removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 11, 2024
shonibare
shonibare approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

driusan
driusan reviewed Nov 14, 2024
View reviewed changes
php/libraries/NDB_BVL_InstrumentStatus.class.inc Outdated
['CommentID' => $this->_commentID]
);

$GLOBALS['DB']->update(
Copy link
Collaborator

@driusan driusan Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the flag table has enum('In Progress','Complete') for Data_entry while the participant_accounts has enum('Created','Sent','In Progress','Complete') .

The instrument (flag) gets set to "In Progress" when it's accessed if the value is null, which will cause the participant_accounts value to get overwritten with "In Progress" if a data entry staff accesses the instrument after it's sent/created, even if the participant has never seen it.

I think this is only intended to be done if the value is "Complete"

@driusan driusan merged commit 63658d2 into aces:main Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan left review comments

@shonibare shonibare shonibare approved these changes

Assignees

@shonibare shonibare

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@victori444 @kongtiaowang @driusan @shonibare @CamilleBeau