[document_repository] Error for filenames with comma #9461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Why can't file names contain commas? |
Contributor
Author
|
Chrome has a restriction that prevents users from downloading files with commas in their names |
Collaborator
|
@victori444 Check if #9029 fixes this issue |
Contributor
Author
Collaborator
|
@victori444 did you verify that that works? If so, can you update the PR and assign it to @racostas to test/review (@racostas don't forget to make sure there aren't regressions with #9029) |
Contributor
Author
|
Update: the above comment does not work. Instead, I've removed the PR's original changes and allow for files with commas in their name to be uploaded by encoding the filenames when downloading |
racostas
approved these changes
Nov 18, 2024
Contributor
racostas
left a comment
There was a problem hiding this comment.
Changes are looking good in my end, I was able to upload, then download a file with a "," on it. Also compatible with a file with "spaces" on it ].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
In the Document Repository module's upload file section, have an error message appear when an uploaded file's name contains a comma
Testing instructions (if applicable)
CCNA Override