[cleanup] PaginationLinks as functional tsx component #10218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Sent as a draft to be sure it doesn't accidentally get merged before the release (or at least before the release branch is created.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PaginationLinks was the first React component ever written in LORIS. As such, it is currently a class based component written in Javascript. It also dated from a time where some pages were partially in React while other parts of the page were smarty and it had to be included in getJSDependencies().
This rewrites the component in typescript as a functional component and stops it from being placed in htdocs, now that it is imported everywhere and we do not have any hybrid pages anymore.