Skip to content

Brainhack MTL 2015: Acknowledgement Generator #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samirdas merged 59 commits into from
Mar 29, 2016
Merged

Brainhack MTL 2015: Acknowledgement Generator #1489

samirdas merged 59 commits into from
Mar 29, 2016

Conversation

@Jkat
Copy link
Contributor

@Jkat Jkat commented Jan 18, 2016

Went through the process of developing a completely new module for LORIS from scratch. The purpose of the Acknowledgement Generator is to aid in dynamically generating an appropriate list of people to acknowledge for any given publication.

There wasn't enough time to do any crazy hacking so many improvements can be made. Nonetheless it is a working prototype.

@Jkat Jkat added Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code labels Jan 18, 2016
@Jkat Jkat added this to the 16.04 milestone Jan 18, 2016
@codecov-io
Copy link

codecov-io commented Jan 18, 2016

Current coverage is 14.50%

Merging #1489 into 16.04-dev will decrease coverage by -0.17% as of d7c680c

@@            16.04-dev   #1489   diff @@
=========================================
  Files             112     113     +1
  Stmts           18836   18969   +133
  Branches            0       0       
  Methods          1046    1051     +5
=========================================
- Hit              2764    2752    -12
  Partial             0       0       
- Missed          16072   16217   +145

Review entire Coverage Diff as of d7c680c

Powered by Codecov. Updated on successful CI builds.

driusan
driusan reviewed Jan 20, 2016
View reviewed changes
SQL/0000-00-02-Menus.sql Outdated
Copy link
Collaborator

@driusan driusan Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably make more sense to put this under "Tools" instead of another top level menu with 1 item. (Also, there's 2 semicolons here.

Jkat added 22 commits March 17, 2016 14:11
@Jkat Jkat force-pushed the the_usual_suspects branch from 7566510 to 1c3daae Compare March 17, 2016 18:12
@driusan driusan assigned kongtiaowang and unassigned Jkat Mar 18, 2016
kongtiaowang
kongtiaowang reviewed Mar 21, 2016
View reviewed changes
SQL/2016-01-18-Acknowledgements.sql Outdated
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

INSERT INTO LorisMenu (Label, OrderNumber) VALUES ('Acknowledgements', 7);
INSERT INTO LorisMenu (Label, Link, Parent, OrderNumber) VALUES ('Acknowledgements','main.php?test_name=acknowledgements', (SELECT ID FROM LorisMenu as L WHERE Label='Acknowledgements'), 1);
Copy link
Contributor

@kongtiaowang kongtiaowang Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure use "main.php" here.

Copy link
Contributor Author

@Jkat Jkat Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Will fix, thanks!

@samirdas samirdas merged commit d789bd5 into aces:16.04-dev Mar 29, 2016
@christinerogers christinerogers added the Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release label Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kongtiaowang kongtiaowang

Labels

Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Jkat @codecov-io @driusan @kongtiaowang @samirdas @christinerogers