Skip to content

Dynamic log display of the MRI pipeline results for a scan. #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xlecours merged 1 commit into from
Apr 1, 2016
Merged

Dynamic log display of the MRI pipeline results for a scan. #1654

xlecours merged 1 commit into from
Apr 1, 2016

Conversation

@nicolasbrossard
Copy link
Contributor

@nicolasbrossard nicolasbrossard commented Mar 29, 2016

Improvements to the imaging uploader page:

  • Added a column to the MRI upload table for the upload progress (MRI pipeline run status)
  • Added click event handler to the MRI upload table: this handler will update the contents of the logs sub-panel (see below).
  • Added a sub panel to show the notifications (logs) issued by the MRI pipeline during an upload. The contents are dynamic and updated by regularly polling the server. Two types of logs can be displayed: summary (Verbose = 'N' in notification_spool table) or detailed (Verbose value does not matter).

@codecov-io
Copy link

codecov-io commented Mar 29, 2016

Current coverage is 14.50%

Merging #1654 into 16.04-dev will decrease coverage by -0.07% as of e73eae5

@@            16.04-dev   #1654   diff @@
=========================================
  Files             113     113       
  Stmts           18997   19030    +33
  Branches            0       0       
  Methods          1052    1053     +1
=========================================
- Hit              2769    2760     -9
  Partial             0       0       
- Missed          16228   16270    +42

Review entire Coverage Diff as of e73eae5

Powered by Codecov. Updated on successful CI builds.

@MounaSafiHarab MounaSafiHarab added this to the 16.0 milestone Mar 31, 2016
@MounaSafiHarab MounaSafiHarab self-assigned this Mar 31, 2016
@MounaSafiHarab MounaSafiHarab added Release: Add to release notes PR whose changes should be highlighted in the release notes Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code labels Mar 31, 2016
MounaSafiHarab
MounaSafiHarab reviewed Mar 31, 2016
View reviewed changes
SQL/2016-01-22-CurrentlyProcessedRenamedInMRIUploadTable.sql
@@ -1,2 +1,2 @@
ALTER TABLE mri_upload CHANGE `Processed` `InsertionComplete` tinyint(1) NOT NULL DEFAULT '0';
ALTER TABLE mri_upload CHANGE `CurrentlyProcessed` `Inserting` tinyint(1) NOT NULL DEFAULT '0';
ALTER TABLE mri_upload CHANGE `CurrentlyProcessed` `Inserting` tinyint(1) DEFAULT NULL;
Copy link
Contributor

@MounaSafiHarab MounaSafiHarab Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will allow me to set more easily the condition for launching Loris-MRI cronjob (imaging_upload_fil_cronjob.pl)!

@xlecours
Copy link
Contributor

xlecours commented Apr 1, 2016

@nicolasbrossard speak to @MounaSafiHarab

@xlecours xlecours merged commit f88c0d4 into aces:16.04-dev Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MounaSafiHarab MounaSafiHarab

Labels

Category: Feature PR or issue that aims to introduce a new feature Language: SQL PR or issue that update SQL code Release: Add to release notes PR whose changes should be highlighted in the release notes

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolasbrossard @codecov-io @xlecours @MounaSafiHarab