Skip to content

[Core] Fixing Instrument setup function call definitions #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driusan merged 3 commits into from
Oct 5, 2017
Merged

[Core] Fixing Instrument setup function call definitions #2916

driusan merged 3 commits into from
Oct 5, 2017

Conversation

@Jkat
Copy link
Contributor

@Jkat Jkat commented Jun 28, 2017

Fixing PHP warnings generated by #2812.

Developers should fix their code accordingly.

@Jkat Jkat added this to the 17.1 milestone Jun 28, 2017
@Jkat Jkat added Release: Add to release notes PR whose changes should be highlighted in the release notes Category: Bug PR or issue that aims to report or fix a bug Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Category: Cleanup PR or issue introducing/requiring at least one clean-up operation Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release labels Jun 28, 2017
@driusan driusan modified the milestones: 17.2, 17.1 Jun 28, 2017
@llevitis llevitis self-assigned this Jul 12, 2017
@johnsaigle
Copy link
Contributor

johnsaigle commented Jul 19, 2017

@llevitis did you intend to test this?

@ridz1208 ridz1208 added the Passed manual tests PR has been successfully tested by at least one peer label Aug 7, 2017
@ridz1208
Copy link
Collaborator

ridz1208 commented Aug 7, 2017

NOTE: all projects should go over instruments extending any of these classes and do a similar change to avoid PHP notices in the error log

@ridz1208 ridz1208 changed the base branch from 17.1-dev to 17.2-dev August 7, 2017 12:11
@driusan driusan closed this Aug 7, 2017
@ridz1208 ridz1208 changed the base branch from 17.2-dev to 17.1-dev August 7, 2017 13:34
@ridz1208 ridz1208 reopened this Aug 7, 2017
@driusan driusan removed this from the 18.1 milestone Oct 2, 2017
@driusan driusan added [branch] bugfix and removed Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects labels Oct 2, 2017
@driusan driusan changed the base branch from 17.1-dev to bugfix October 5, 2017 17:55
@driusan driusan merged commit 215d69f into aces:bugfix Oct 5, 2017
@driusan driusan added this to the 18.0.1 milestone Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jstirling91 jstirling91 jstirling91 approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@llevitis llevitis

Labels

Category: Bug PR or issue that aims to report or fix a bug Category: Cleanup PR or issue introducing/requiring at least one clean-up operation Passed manual tests PR has been successfully tested by at least one peer Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release

Projects

None yet

Milestone

18.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@Jkat @johnsaigle @ridz1208 @jstirling91 @driusan @llevitis