feat: added solo banner #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-lily-87250a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new solo banner component along with its integration into the app layout and updates to related UI components and styling.
- Introduces a Banner component with close functionality.
- Extends the title section with a registration link.
- Incorporates utility functions and updates to global CSS and package dependencies.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/utils.ts | Adds a utility function for merging CSS class names. |
| src/components/ui/button.tsx | Implements a customizable button component with variant options. |
| src/components/TitleSection.tsx | Adds a registration link element in the title section. |
| src/components/Banner.tsx | Introduces the new Banner component with a close button feature. |
| src/app/layout.tsx | Integrates the Banner component into the global layout. |
| src/app/globals.css | Updates and extends global theme definitions and imports. |
| package.json | Updates dependencies and adds new packages required for new features. |
| components.json | Adds UI schema configuration for component aliases and styling options. |
| if (!isVisible) return null; | ||
|
|
||
| return ( | ||
| <section className="sticky top-0 w-full bg-[#00694E] px-4 py-3 shadow-sm z-47000"> |
There was a problem hiding this comment.
[nitpick] Consider using a theme variable or a named CSS class for the z-index value instead of a hard-coded magic number, to improve maintainability.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.