Skip to content

Conversation

@fidian
Copy link
Contributor

@fidian fidian commented Feb 16, 2022

A follow-up to #400

Updating packages.

  • Chalk is not at 5.x.x branch because it's now using ESM - picked 4.x.x
  • Commander's parsed options are now retrieved via a method
  • XRegExp now captures named groups under "groups"
  • Updating packages to eliminate vulnerable packages

@coveralls
Copy link

coveralls commented Feb 16, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 1e0248c on fidian:package-update-try-2 into 0c26521 on acss-io:master.

@src-code
Copy link
Contributor

Thanks @fidian! Will review shortly

@src-code
Copy link
Contributor

There still seems to be something not quite right, if I run current Atomizer against a simple test file

<div class="Bgc(foobar)">
  <div class="Trfo(t,c)"></div>
</div>

I get this:

$ ./bin/atomizer test.txt 
Parsing file test.txt for Atomic CSS classes

.Trfo\(t\,c\) {
  transform-origin: top center;
}

But if I run it against this change, I get no output from Atomizer

$ ./bin/atomizer test.txt 


@fidian
Copy link
Contributor Author

fidian commented Feb 17, 2022

Weirdly, it works for me.
image

@src-code
Copy link
Contributor

@fidian Can you verify that you re-installed all npm dependencies after switching branches?

@fidian
Copy link
Contributor Author

fidian commented Feb 21, 2022

I tried it and it worked, then I deleted node_modules and package-lock.json, reinstalled, and the command no longer worked. Very bizarre since it should not have worked when I ran it earlier, but I could't scroll back far enough to figure out if I was delusional or I had really seen it working.

Added a bugfix to make it work for real and updated packages again.

@src-code src-code merged commit 074f034 into acss-io:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants