Skip to content

Handle cases would break the code #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
src-code merged 2 commits into from
Mar 31, 2020
Merged

Handle cases would break the code #359

src-code merged 2 commits into from
Mar 31, 2020

Conversation

@tom76kimo
Copy link
Contributor

@tom76kimo tom76kimo commented Dec 3, 2019

Based on #358, though I think it's a rare case, we can still add defensive code here to prevent possible bug.
How do you think? @src-code @redonkulus

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage decreased (-0.3%) to 99.749% when pulling 67194b0 on tom76kimo:fix into 0dc7aac on acss-io:master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage decreased (-0.3%) to 99.749% when pulling 67194b0 on tom76kimo:fix into 0dc7aac on acss-io:master.

@coveralls
Copy link

coveralls commented Dec 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1f9c9fd on tom76kimo:fix into 0dc7aac on acss-io:master.

@tom76kimo
Copy link
Contributor Author

tom76kimo commented Jan 12, 2020

@redonkulus @src-code

@src-code src-code merged commit 9937fad into acss-io:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@src-code src-code src-code approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom76kimo @coveralls @src-code