Chunked Cache Upload APIs #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarenner
reviewed
Dec 13, 2019
zarenner
requested changes
Dec 14, 2019
Collaborator
zarenner
left a comment
There was a problem hiding this comment.
Reserve before tarring up cache?
7f6523f to
71d9426
Compare
Collaborator
|
Implement a (very small number of) retries as discussed, or did you decide not to? |
Contributor
Author
|
@zarenner I've added retries to the upload chunk requests |
zarenner
reviewed
Dec 19, 2019
zarenner
reviewed
Dec 19, 2019
zarenner
reviewed
Dec 19, 2019
zarenner
reviewed
Dec 19, 2019
zarenner
reviewed
Dec 19, 2019
zarenner
approved these changes
Dec 19, 2019
yacaovsnc
reviewed
Dec 20, 2019
src/cacheHttpClient.ts
Outdated
| ? fileSize - offset | ||
| : MAX_CHUNK_SIZE; | ||
| const start = offset; | ||
| const end = offset + chunkSize - 1; |
Contributor
There was a problem hiding this comment.
What happens when we try to upload a size 0 file, i.e. when end is -1, what happens?
Contributor
Author
There was a problem hiding this comment.
In that case:
offset = 0, chunkSize = fileSize - offset = 1, end = 0, which is valid since the content range is inclusive
Is a size 0 file valid? I'd imagine something else will fail before it gets here
yacaovsnc
reviewed
Dec 20, 2019
yacaovsnc
reviewed
Dec 20, 2019
yacaovsnc
approved these changes
Dec 20, 2019
pjquirk
reviewed
Dec 20, 2019
pjquirk
reviewed
Dec 20, 2019
pjquirk
reviewed
Dec 20, 2019
pjquirk
reviewed
Dec 20, 2019
pjquirk
reviewed
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable larger cache sizes, we're updating our internal APIs to prevent network timeouts that occur from the large single upload stream of the previous iteration.
Bumping the per cache limit to match the per repo limit, as that's the only limit we have now.