Better error handling during download #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiqiaoy
approved these changes
Apr 29, 2020
Contributor
|
the promisified pipeline simplifies things quite a bit :) - fyi docs here: https://nodejs.org/dist/latest-v12.x/docs/api/stream.html#stream_stream_pipeline_streams_callback |
ericsciple
approved these changes
Apr 29, 2020
44d3fd8 to
1ed0c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error handling by using the same fix described in actions/toolkit#369.
For example, in the case the download stream is interrupted before all bytes are downloaded, this will raise the error
Premature close. This should eliminate the need to check the content length header, but it also doesn't hurt to leave the content length check in place.