stale-issue/pr-message is required even if skip-stale-issue/pr-message is set to true

stale-issue-message / stale-pr-message should probably not be required if skip-stale-issue-message / skip-stale-pr-message is set to true, since that string never gets used.

Workaround: set skip-stale-issue-message / skip-stale-pr-message to a non-empty string.

I think this happens because the check for a commit message (

stale/src/classes/issues-processor.ts

Lines 151 to 156 in b717aa9

    
           const shouldMarkAsStale: boolean = shouldMarkWhenStale(daysBeforeStale); 
        
           if (!staleMessage && shouldMarkAsStale) { 
        
             issueLogger.info(`Skipping $$type due to empty stale message`); 
        
             continue; 
        
           }

) comes before we check if an issue is stale (

stale/src/classes/issues-processor.ts

Lines 265 to 269 in b717aa9

    
           if (!issue.isStale && shouldBeStale && shouldMarkAsStale) { 
        
             issueLogger.info( 
        
               `Marking $$type stale because it was last updated on ${issue.updated_at} and it does not have a stale label` 
        
             ); 
        
             await this._markStale(issue, staleMessage, staleLabel, skipMessage);

).

Example workflow: https://github.com/neverendingqs/serverless-dotenv-plugin/blob/8c02adbc653a90d681d5ededbb40300677cb8eac/.github/workflows/issues-cron.yml

Example run: https://github.com/neverendingqs/serverless-dotenv-plugin/runs/2209947040?check_suite_focus=true#step:2:35

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

up

Related to #455

feat(options): simplify config by removing skip stale message options

feat(options): simplify config by removing skip stale message options (…

Navigation Menu

Repository navigation

`stale-issue/pr-message` is required even if `skip-stale-issue/pr-message` is set to `true` #405

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const shouldMarkAsStale: boolean = shouldMarkWhenStale(daysBeforeStale);

	if (!staleMessage && shouldMarkAsStale) {
	issueLogger.info(`Skipping $$type due to empty stale message`);
	continue;
	}

	if (!issue.isStale && shouldBeStale && shouldMarkAsStale) {
	issueLogger.info(
	`Marking $$type stale because it was last updated on ${issue.updated_at} and it does not have a stale label`
	);
	await this._markStale(issue, staleMessage, staleLabel, skipMessage);

stale-issue/pr-message is required even if skip-stale-issue/pr-message is set to true #405

Description

Activity

github-actions commented on Apr 27, 2021

C0ZEN commented on Apr 27, 2021

C0ZEN commented on May 23, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`stale-issue/pr-message` is required even if `skip-stale-issue/pr-message` is set to `true` #405