fix(release): move WFWEB_VERSION into a header so bumps actually rebuild#65
Merged
Conversation
Bumping WFWEB_VERSION via a -D flag in wfweb.pro silently leaves stale .o files behind: Make tracks file mtimes, not changes to compiler flags. v0.7.1 hit this — webserver.o and main.o happened to rebuild from unrelated touches and embedded "0.7.1", but freedvreporter.o / pskreporter.o stayed at "0.7.0", so the splash showed v0.7.1 while the FreeDV Reporter session announced wfweb 0.7.0. Move the macro to include/wfweb_version.h, add it to HEADERS so qmake emits a real dependency, and #include it from the four consumers (freedvreporter, pskreporter, webserver, main). Touching the header now forces every consumer to rebuild and the binary version stays self-consistent across all surfaces. Named wfweb_version.h, not version.h, because resources/direwolf/src ships its own version.h earlier on the include path and would shadow ours. Updated tools/build-static.sh and .github/workflows/build.yml (3 jobs) to grep the new file, and rewrote .claude/commands/release.md so future release work points at the header. Bumps to v0.7.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
#64 (rigctld) and #63 (CW decoder leaves CW) both landed on master after this branch was cut. Roll their entries into the v0.7.2 section so the final release notes cover everything shipping in 0.7.2, not just the version-header fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7be47a3 to
4587848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
v0.7.1 was a `DEFINES`-only change. Make tracks file mtimes, not compiler flags, so `make` after the bump rebuilt nothing — except for files whose mtimes happened to change for unrelated reasons. Result: `webserver.o` / `main.o` were rebuilt with WFWEB_VERSION="0.7.1" while `freedvreporter.o` / `pskreporter.o` stayed compiled against "0.7.0". The splash showed v0.7.1 but the FreeDV Reporter session announced `wfweb 0.7.0`. `strings -e l freedvreporter.o` confirmed the stale UTF-16 literal in the .o.
Changes
Test plan
🤖 Generated with Claude Code